Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datamatrix: first FNC1 as ascii 232 #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mutm
Copy link

@mutm mutm commented Apr 24, 2021

To support GS1 Datamatrix format

To support GS1 Datamatrix format
@codecov-commenter
Copy link

Codecov Report

Merging #42 (2ba9850) into master (57132e8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         118      118           
  Lines        8285     8288    +3     
=======================================
+ Hits         8119     8122    +3     
  Misses         97       97           
  Partials       69       69           
Impacted Files Coverage Δ
datamatrix/encoder/high_level_encoder.go 97.22% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57132e8...2ba9850. Read the comment docs.

@makiuchi-d
Copy link
Owner

makiuchi-d commented Apr 30, 2021

Thank you for your contribution.

IMO, it should be indicated by EncodeHintType_GS1_FORMAT rather than a charactor \u00e8.
And it need to implement the decoder support.

I want it be implemented on the original ZXing before this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants