feat: decoupled aria-expanded state #227#228
Merged
ianmcburnie merged 6 commits intomasterfrom Feb 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR decouples the expander's state management from the DOM by introducing an internal _expanded property, allowing the component to work without relying on aria-expanded attributes. This addresses issue #227 by making aria-expanded optional through a new useAriaExpanded configuration option.
Changes:
- Added internal
_expandedstate property to track expansion state independently from DOM - Introduced
useAriaExpandedoption (default: true) to makearia-expandedattribute usage optional - Updated documentation to reflect the new option and clarify use cases for tooltips
Reviewed changes
Copilot reviewed 4 out of 14 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/makeup-expander/src/index.js | Added _expanded internal state and useAriaExpanded option to conditionally manage aria-expanded attribute |
| packages/core/makeup-expander/README.md | Updated documentation to describe new option and removed deprecated methods section |
| docs/core/makeup-expander/index.js | Added tooltip example demonstrating useAriaExpanded: false usage |
| docs/core/makeup-expander/index.html | Added HTML markup for tooltip demonstration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
saiponnada
reviewed
Feb 5, 2026
Co-authored-by: Goutham Ponnada <sponnada@ebay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick and dirty fix for #227. Decouples expander state from the DOM. All tests still passing.