chore(core): Add type declaration files for core packages#224
Merged
ianmcburnie merged 3 commits intomakeup:masterfrom Jan 13, 2026
Merged
chore(core): Add type declaration files for core packages#224ianmcburnie merged 3 commits intomakeup:masterfrom
ianmcburnie merged 3 commits intomakeup:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds TypeScript type declaration files to all core makeup-js packages to improve TypeScript support without requiring a full migration to TypeScript.
- Adds
index.d.tstype declaration files to the/distdirectory of each core package - Updates
package.jsonfiles to reference the new type declarations viatypesfield - Includes type declaration files in the published package files array
Reviewed changes
Copilot reviewed 13 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/makeup-typeahead/package.json | Adds type declaration references for the typeahead package |
| packages/core/makeup-screenreader-trap/package.json | Adds type declaration references for the screenreader trap package |
| packages/core/makeup-roving-tabindex/package.json | Adds type declaration references for the roving tabindex package |
| packages/core/makeup-prevent-scroll-keys/package.json | Adds type declaration references for the prevent scroll keys package |
| packages/core/makeup-next-id/package.json | Adds type declaration references for the next-id package |
| packages/core/makeup-navigation-emitter/package.json | Adds type declaration references for the navigation emitter package |
| packages/core/makeup-modal/package.json | Adds type declaration references for the modal package |
| packages/core/makeup-keyboard-trap/package.json | Adds type declaration references for the keyboard trap package |
| packages/core/makeup-key-emitter/package.json | Adds type declaration references for the key emitter package |
| packages/core/makeup-focusables/package.json | Adds type declaration references for the focusables package |
| packages/core/makeup-expander/package.json | Adds type declaration references for the expander package |
| packages/core/makeup-exit-emitter/package.json | Adds type declaration references for the exit emitter package |
| packages/core/makeup-active-descendant/package.json | Adds type declaration references for the active descendant package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LuLaValva
approved these changes
Jan 7, 2026
Contributor
LuLaValva
left a comment
There was a problem hiding this comment.
Thanks for doing this @caseycarroll! Since types don't effect functionality it should be okay to merge as-is and we can do a follow-up if any issues come up later.
Member
|
Nice! Thank you! We'll get this published soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #223
What
Adds type declaration file for each core package.
Why
TypeScript consumers of makeup-js must provide ambient module declarations for makeup exports.
How
I used an LLM to consider the README and implementations of each export to infer correct type definitions. Definitions are documented via TSDoc conventions.
Types are included in
/distdir of each package. Each package config defines "types" to point to its respective type file.Ideal solution involves migrating libraries to TS. The team plans to migrate to new repo in the future, so this low effort patch seems more appropriate.