fix(keyboard-trap): fixed a server rendering bug#217
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a server-side rendering bug in the keyboard trap component where importing the module would break on the server due to a globally defined MutationObserver. The fix adds a window check to conditionally initialize the observer only in browser environments.
- Added conditional initialization of the MutationObserver based on window availability
- Updated observer usage to handle null cases with optional chaining
- Moved observer declaration to the top of the file for better organization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
ianmcburnie
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug when you import keyboard trap on the server that it breaks.
This is because the observer is globally defined.
It should only break if you call "trap" on the server.
Added a check to only initialize the observer if window is defined.