Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove React Router #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove React Router #129

wants to merge 1 commit into from

Conversation

JohnForster
Copy link
Contributor

React Router is industry standard, and very powerful, but in the past has been a big stumbling block to understanding what's going on in the template repo. This PR removes it, instead opting for a single state value that determines which page to render.

Hopefully this will help reinforce the idea of the frontend as a Single Page Application, distinguishing it from the types of applications learners have built previously. Adding (and understanding!) React Router could then be a ticket on the Acebook Trello.

I'm not 100% sure about this change, because it does make the application harder to use. Specifically, not being able to use the back button is a pain, but maybe this pain is actually a good thing, as they will understand the utility of React Router once they add it?

Definitely one for discussion, so please let me know your thoughts.

@ClaireMakers
Copy link

Would you say the last group you ran Acebook with really struggled with the React Router and the notion that these aren't real "routes" to other pages, but more like a switchboard of which components to display?

I don't know if the groups would manage to add it from scratch themselves, converting this version with a hook into the router itself, or if they'd see the point in doing it that way? While it might feel difficult when it's already implemented, having the code there and figuring out how to use it is also one way of learning about React Router? I'm not 100% sure either what approach would be better :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants