Fix for skeinforge comb crash on thin structures. #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix issue #268. |
|
I just cherry-picked this for testing. Can you link to a thingiverse object that shows this bug? That way I can test it and verify the fix. thanks for helping make our software (and since it's open source, a lot of other folk's software) better, stronger, and more bug-free.
|
|
Skeining http://www.thingiverse.com/thing:12249 causes the comb crash. |
|
+1 for getting this fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When skeining extremely thin structures comb.py has the potential to crash. Removing .boundary allows the code to function correctly.
Credit to Daid for finding this: http://groups.google.com/group/ultimaker/msg/576f52b1407e901a