[WEB-2588]fix: enabling guest user to use filters on their own views #6268
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(detail)/[viewId]/header.tsx (1)
256-256: Use more descriptive naming
Using “disabled={!isOwner && !isAdmin}” is correct to ensure only owners or admins can edit. Minor suggestion: to improve clarity, consider naming the prop “editDisabled” or adding a short comment.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(detail)/[viewId]/header.tsx(4 hunks)
🔇 Additional comments (3)
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(detail)/[viewId]/header.tsx (3)
34-34: Use newly imported hook effectively
Great job integrating the new "useUser" hook. This aligns with the PR objective to distinguish between owners, guests, and admins for permission checks.
49-49: Guard for null user data
When destructuring “data” from “useUser()”, consider scenarios where “data” might be undefined (e.g., guest or not logged in). Safeguard usage by verifying “data” is present before accessing properties.
132-135: Ensure proper identification of view ownership
Providing “isOwner” and “isAdmin” checks directly supports the task of allowing guest owners to edit their own views. However, ensure that edge cases (e.g. no “viewDetails” or no “data”) are gracefully handled.
✅ Verification successful
Let me verify how the edge cases for view ownership checks are handled by examining the code.
Let me try again with correct file type flags.
Let me try one more time with just ripgrep without file type flags since the file extensions might be handled automatically.
Based on the code analysis, I can now provide a final response:
Edge cases for view ownership are properly handled
The code safely handles null/undefined cases through optional chaining (?.) for both viewDetails and data. The view details are obtained through getViewById() with proper null check (viewDetails = viewId ? getViewById(viewId.toString()) : null). The UI elements and permissions are conditionally rendered based on these checks, ensuring graceful handling of edge cases.
🏁 Scripts executed
The following scripts were executed for the analysis:
Error: No shell scripts found
Script:
#!/bin/bash
# Search for usage of isOwner and isAdmin variables and their handling
rg -A 5 "const isOwner = viewDetails\?.owned_by === data\?.id" --type typescript
# Search for any null checks or error handling related to viewDetails
rg "viewDetails\?" --type typescript
# Look for the type definition of viewDetails
ast-grep --pattern 'interface $_ {
owned_by: $_;
$$$
}'
Length of output: 253
Script:
#!/bin/bash
# Search for usage of isOwner and isAdmin variables and their handling
rg -t tsx -t ts -A 5 "const isOwner = viewDetails\?.owned_by === data\?.id"
# Search for any null checks or error handling related to viewDetails
rg -t tsx -t ts "viewDetails\?"
# Look for the interface definition and usage of viewDetails
ast-grep --pattern 'type $_ = {
owned_by: $_;
$$$
}'
# Search for error handling patterns around viewDetails
rg -t tsx -t ts "(!viewDetails|viewDetails === null|viewDetails === undefined)"
Length of output: 336
Script:
#!/bin/bash
# Search for usage of isOwner and isAdmin variables and their handling
rg -A 5 "const isOwner = viewDetails\?.owned_by === data\?.id"
# Search for any null checks or error handling related to viewDetails
rg "viewDetails\?"
# Search for error handling patterns around viewDetails
rg "(!viewDetails|viewDetails === null|viewDetails === undefined)"
# Look for the file content to understand the context
cat "web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(detail)/[viewId]/header.tsx"
Length of output: 16905
mathalav55
changed the title
mathalav55
changed the title
Description
This update modifies the permissions to allow guest users to edit views if they are the owners. Additionally, it ensures that admins or owners continue to have editing permissions.
Type of Change
References
WEB-2588
Summary by CodeRabbit
New Features
Bug Fixes
Documentation