Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PHP 8.2 #5099

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Update to PHP 8.2 #5099

merged 3 commits into from
Mar 27, 2023

Conversation

MAGICCC
Copy link
Member

@MAGICCC MAGICCC commented Feb 28, 2023

This PR updates the phpfpm container to PHP 8.2
Also fixes CVE-2023-0567

Currently I am testing it on my instance

@MAGICCC
Copy link
Member Author

MAGICCC commented Mar 2, 2023

Looks okish on my instance.
Would need a push to Dockerhub

@MAGICCC MAGICCC marked this pull request as ready for review March 2, 2023 19:01
@MAGICCC MAGICCC requested a review from DerLinkman March 2, 2023 19:01
@accolon
Copy link
Contributor

accolon commented Mar 2, 2023

Nextcloud 25 doesn't support PHP 8.2 yet, but Nextcloud 26 (which is expected on 2023-03-21) will:
nextcloud/server#32595

Updating to PHP 8.2 will probably cause issues for people using the current mailcow NC integration and require an update to NC 26 beforehand.

@DerLinkman
Copy link
Member

Nextcloud 25 doesn't support PHP 8.1 yet, but Nextcloud 26 (which is expected on 2023-03-21) will: nextcloud/server#32595

Updating to PHP 8.2 will probably cause issues for people using the current mailcow NC integration and require an update to NC 26 beforehand.

Then we wait for nextcloud 26 until we merge this :)

@MAGICCC
Copy link
Member Author

MAGICCC commented Mar 3, 2023

Indeed yes I forgot, it's a pain that Nextcloud didnt backported the check in 25

@meizfl
Copy link

meizfl commented Mar 7, 2023

for nextcloud 24/25 wrote an easy temporary fix that disables php version checking. everything works stable on nextcloud 24.0.10 and 25.0.4 . just replace versioncheck.php file in /nextcloud/lib/ directory. https://github.com/meizuflym/nextcloudversioncheckfix/releases

Copy link
Member

@DerLinkman DerLinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DerLinkman DerLinkman merged commit f7798d1 into staging Mar 27, 2023
@DerLinkman DerLinkman deleted the feat/phpfpm-8.2 branch March 27, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants