Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heaptrack builds non musl #21

Closed
wants to merge 10 commits into from
Closed

heaptrack builds non musl #21

wants to merge 10 commits into from

Conversation

joshuef
Copy link
Contributor

@joshuef joshuef commented Oct 2, 2023

No description provided.

@joshuef
Copy link
Contributor Author

joshuef commented Oct 2, 2023

I'm unsure of the desirability of this in main atm... But this does get heaptrack going properly. (non musl builds being key)

@jacderida
Copy link
Contributor

I'm unsure of the desirability of this in main atm... But this does get heaptrack going properly. (non musl builds being key)

Yeah, I would suggest if we could wait for a little bit before this goes into main so that we can make heaptrack properly optional.

@joshuef joshuef force-pushed the HeaptrackProperly branch from 1a9cf17 to e898aec Compare October 3, 2023 13:35
@joshuef joshuef force-pushed the HeaptrackProperly branch 3 times, most recently from 2f90a27 to e9b19ee Compare October 29, 2023 13:06
@joshuef joshuef force-pushed the HeaptrackProperly branch 2 times, most recently from 73896f7 to 9514c84 Compare November 17, 2023 09:21
@jacderida
Copy link
Contributor

Honestly this is so old, I don't even know what it's really for.

Just going to close.

@jacderida jacderida closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuef @jacderida