Rename "ueIdLst" to "ueS1apIdPairList" so Test Controller Complies#39
Rename "ueIdLst" to "ueS1apIdPairList" so Test Controller Complies#39nickvsnetworking wants to merge 4 commits intomagma:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
| ((ResetReq*)msgptr)->r.partialRst.numOfConn = numOfUes; | ||
| ((ResetReq*)msgptr)->r.partialRst.ueIdLst = malloc(numOfUes); | ||
| memcpy(((ResetReq*)msgptr)->r.partialRst.ueIdLst, ueLst, numOfUes); | ||
| ((ResetReq*)msgptr)->r.partialRst.ueS1apIdPairList = malloc(numOfUes); |
There was a problem hiding this comment.
This malloc memory allocation and typecasting looks invalid. "ueIdLst" was a list of U32 UEId values, whereas "ueS1apIdPairList" is a list with structures of 3 U32 values inside each. I believe, this should be like:
((ResetReq*)msgptr)->r.partialRst.ueS1apIdPairList =
(NbUeS1apIdPair) malloc(sizeof(NbUeS1apIdPair) * numOfUes);
| ((ResetReq*)msgptr)->r.partialRst.ueIdLst = malloc(numOfUes); | ||
| memcpy(((ResetReq*)msgptr)->r.partialRst.ueIdLst, ueLst, numOfUes); | ||
| ((ResetReq*)msgptr)->r.partialRst.ueS1apIdPairList = malloc(numOfUes); | ||
| memcpy(((ResetReq*)msgptr)->r.partialRst.ueS1apIdPairList, ueLst, numOfUes); |
There was a problem hiding this comment.
Similar to the above comment, this memcpy here should be updated as well. Moreover, the "ueLst" variable needs to be updated for this function with the new structure of "ueS1apIdPairList".
ulaskozat
left a comment
ulaskozat
left a comment
There was a problem hiding this comment.
Please make the requested changes.
|
Hi @nickvsnetworking, do you plan to invest on this PR and address the comments? |
|
Will try suggested changes and make sure it all compiles before updating PR, |
5 participants
Title
Rename "ueIdLst" to "ueS1apIdPairList" so Test Controller Complies
Summary
Changed variables named "ueIdLst" to "ueS1apIdPairList" in file
TestCntlrStub/src/ts_utls.cas outlined in issue here.Test plan
Confirmed compiled on test environment (was failing prior to change)