Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test and lint scripts #99

Merged
merged 2 commits into from
Nov 29, 2024
Merged

test: test and lint scripts #99

merged 2 commits into from
Nov 29, 2024

Conversation

notdanilo
Copy link
Contributor

Status Type ⚠️ Core Change Issue
Ready Tooling No None

Problem

  • ./scripts/test.sh is only runnable from project root.
  • We don't have a lint script
  • Code has lint errors

Solution

  • Allow relative paths
  • Implement ./scripts/lint.sh
  • Fix lint errors

@notdanilo notdanilo mentioned this pull request Nov 29, 2024
Closed
@notdanilo notdanilo force-pushed the test/test-and-lint-scripts branch 3 times, most recently from f57d7ad to f7f494e Compare November 29, 2024 05:40
@notdanilo notdanilo force-pushed the test/test-and-lint-scripts branch from f7f494e to 238cbf9 Compare November 29, 2024 06:09
@notdanilo notdanilo force-pushed the test/test-and-lint-scripts branch from 238cbf9 to 817dd70 Compare November 29, 2024 06:31
@notdanilo notdanilo merged commit d597787 into main Nov 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@notdanilo