wip: Use world.key instead of world.id to generate entity PDA #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto-vincent
commented
Jun 18, 2024
| : FindEntityPda({ worldId, entityId: new BN(worldInstance.entities) }); | ||
| let entityPda: PublicKey; | ||
| if (seed !== undefined) { | ||
| entityPda = FindEntityPda({ world, seed }); |
There was a problem hiding this comment.
this is now the happy path, much faster to generate transactions
crypto-vincent
changed the title
crypto-vincent
changed the title
crypto-vincent
changed the title
|
This PR seems old. Is it still an issue? |
Hello there, yes latest master still seem to have the issue: we always have to read the latest world.Id through a "World.fromAccountAddress" before creating any new entity (but seed-based entities may not need to do that in theory) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When adding a new entity using seeds, we have to fetch the WorldId which can needs to be resolved from the onchain state. This means we have to do an RPC call for each transaction we are trying to prepare in those cases.
Solution
An easy solution is just to allow users to generate the Entity PDA from the worldPda instead, that way the users avoid unecessary lookups from the on-chain state when using entity seeds.
Notes
Also change the naming from "extraSeed" to "seed" in the entity API, since this seed effectively replace the "entity id", it's not an addition on top of it.