Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: running lint on pull request #101

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

notdanilo
Copy link
Contributor

Status Type ⚠️ Core Change Issue
Ready Tooling No None

Problem

  1. Wrong assumption that caches was causing issues while the code was being tested on pull_request_target
  2. Linting is running on pull_request_target and not on pull_request

Solution

  1. Bring caching back
  2. Make it run on pull_request to lint incoming changes.

@notdanilo notdanilo merged commit 5283112 into main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant