[MKM] Murders at Karlov Manor Collation #12978
Open
+354
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe there is more work needed for TheList and SpecialGuest cards.
generateBoosterMap
Cards needed are listed in:
private final CardRun list = new CardRun(false, "XLN_91", "DKA_4", "MH2_191", "HOU_149", "RAV_277", "ARB_68", "DIS_173", "ISD_183", "DOM_130", "MH2_46", "RNA_182", "ONS_272", "SOM_96", "VOW_207", "MBS_10", "UMA_138", "DDU_50", "2X2_17", "KLD_221", "M14_213", "UMA_247", "CLB_85", "JOU_153", "APC_117", "STX_220", "SOI_262", "DIS_33", "DKA_143", "ELD_107", "C16_47");
private final CardRun listRare = new CardRun(false, "STX_64", "M20_167", "DST_40", "ONS_89", "WAR_54", "MRD_99", "SOM_98", "C21_19", "MH1_21", "RTR_140");
private final CardRun listGuest = new CardRun(false, "SPG_25", "SPG_27", "SPG_20", "SPG_28", "SPG_24", "SPG_19", "SPG_21", "SPG_26", "SPG_22", "SPG_23" );
corrected typo in RarityConfiguration foilUncommonRuns fuC (was originally listed as fcC)
|
Just found a typo in RarityConfiguration foilUncommonRuns and corrected it. |
It appears I had made an error in my original calculation for commons.
|
deleted since no longer accurate. |
I think I've worked out what was needed. Please check to make sure.
JayDi85
reviewed
Oct 14, 2024
| protected void generateBoosterMap() { | ||
| super.generateBoosterMap(); | ||
| for( let cn = 19 ; cn < 29 ; cn++ ){ | ||
| inBoosterMap.put("SPG_" + cn, CardRepository.instance.findCard("SPG", "" + cn)); |
There was a problem hiding this comment.
Must check findCard result and save only non nullable values. inBoosterMap allow only good objects. Also on null values you can raise error about unknown card (it will help to find typo or non-implemented cards in booster settings).
I am not certain if I used the correct Exception type.
xenohedron
reviewed
Oct 18, 2024
Not sure if I chose the correct exception to raise
I don't know how to delete from my fork, so editing it to nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original comment
I believe there is more work needed for TheList and SpecialGuest cards.generateBoosterMap
Cards needed are listed in:
private final CardRun list = new CardRun(false, "XLN_91", "DKA_4", "MH2_191", "HOU_149", "RAV_277", "ARB_68", "DIS_173", "ISD_183", "DOM_130", "MH2_46", "RNA_182", "ONS_272", "SOM_96", "VOW_207", "MBS_10", "UMA_138", "DDU_50", "2X2_17", "KLD_221", "M14_213", "UMA_247", "CLB_85", "JOU_153", "APC_117", "STX_220", "SOI_262", "DIS_33", "DKA_143", "ELD_107", "C16_47");
private final CardRun listRare = new CardRun(false, "STX_64", "M20_167", "DST_40", "ONS_89", "WAR_54", "MRD_99", "SOM_98", "C21_19", "MH1_21", "RTR_140");
private final CardRun listGuest = new CardRun(false, "SPG_25", "SPG_27", "SPG_20", "SPG_28", "SPG_24", "SPG_19", "SPG_21", "SPG_26", "SPG_22", "SPG_23" );