[J21] Implement Pool of Vigorous Growth #12734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karapuzz14
changed the title
JayDi85
reviewed
Aug 25, 2024
|
|
||
| int xValue = source.getManaCostsToPay().getX(); | ||
| if (game.isSimulation()) { | ||
| // Create dummy token to prevent multiple DB find cards what causes H2 java.lang.IllegalStateException if AI cancels calculation because of time out |
There was a problem hiding this comment.
Can you explain details about broken AI here? Is it catch error all time or at random? How to reproduce that?
There was a problem hiding this comment.
Oh, that's just old comment from Momir's Emblem implementation. I decided that it's known issue and just left the same comment as explanation.
I think it says about next issue:
#7014
There was a problem hiding this comment.
So this trick with dummy token is also stolen from here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Pool of Vigorous Growth, which effect was based on existing Momir's Emblem effect.
I was doubtful about card pool size of its random ability because of possible format limitations, but experiments showed that this card can create a copy of illegal card in Arena (attached screenshot).
However, I decided to set up limitations for joke sets and custom sets. I'm eagerly waiting for comments and opinions.