[40K] Implement The Red Terror #12647
Draft
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
reviewed
Aug 13, 2024
|
|
||
| @Override | ||
| public boolean checkEventType(GameEvent event, Game game) { | ||
| return event.getType() == GameEvent.EventType.DAMAGED_BATCH_FOR_ALL; |
There was a problem hiding this comment.
oof, this is subtly bugged and needs its own batch event, that's a larger scope
example: multiple red sources you control simultaneously deal damage, should be a trigger for each, but they're all combined here
There was a problem hiding this comment.
Do you mean it's possible to use existing events like DAMAGED_BATCH_FOR_PERMANENTS, DAMAGED_BATCH_FOR_PLAYERS? Maybe use them simultaneously? And if so, should I make a checkTrigger for each of them separately?
There was a problem hiding this comment.
No, I mean that a new batch event needs to be added to the engine, one that batches on source instead of target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://scryfall.com/card/40k/83/the-red-terror