in progress attempt at fixing Nadu in edge scenarios #12548
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is far from done. But I'd rather have other devs opinions at this point.
Issue that I try to fix here is that [[Nadu, Winged Wisdom]]'s limit on 2 per permanent is reliant on the given ability
originalId
, and that id stays the same if casting Ephemerate on Nadu, or copying Nadu, which incorrectly prevents the ability to trigger in various situations.The work in progress is at the moment working for Ephemerate, multiple real Nadu, but is not yet working if copying Nadu with a Clone (may add a test on making a token copy too). Issue being the originalIds preserved in the
GainAbilityControlledEffect
gets reset each time the clone's ability are added (which is quite often).I'm not yet 100% sure of at which degree the originalId should be preserved along the copy/addAbility chains, but once I'm happy with Nadu, the changes done should be also done in similar continuous effects.
#12484 for reference on the issue.