Add several new tests #1
Conversation
src/porcupine/utils.rs
Outdated
There was a problem hiding this comment.
Is this module translated from Golang code? It seems like a double linked list.
There is too much unsafe code here. Maybe we should figure out how to write in safe code if possible. 🤔
There was a problem hiding this comment.
Yes, this algorithm was translated from Golang. Most of the unsafe codes were introduced by NonNull, so I wrapped them in a new type. 🤔
There was a problem hiding this comment.
This linked list is totally safe now. 🤔
src/kvraft/tester.rs
Outdated
| lazy_static! { | ||
| static ref T0: Instant = Instant::now(); | ||
| } |
There was a problem hiding this comment.
This looks weird, although I understand it's a workaround for getting current timestamp.
In madsim v0.2 we could use std::time::SystemTime directly to get timestamp of the simulated time.
But it's another long story to upgrade madsim to v0.2...
There was a problem hiding this comment.
Seems there's a lot of work upgrading madsim...🥲 Now I removed the lazy_static stuff and used t0 in Tester as a start timestamp.
refactor: remove timeout, use Result as return value in porcupine
This PR includes some new tests and a tool to check linearizability.