-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify custom volume up/down/mute actions #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oh and scu'ze me for all the commits, had some problems with HACS not reloading the new version so.. idk. |
Just saw #32 , that would be solved by this. |
# Conflicts: # README.md
# Conflicts: # lg-remote-control.js
# Conflicts: # README.md
oh, created this pr from the wrong branch.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I experienced some problems while trying to change the volume of my soundbar (sonos playbar with optical cable to the TV). When configured correctly the playbar does change volume when using the physical remote, but i discovered that this behaviour is achieved by a little hack: when changing the volume the tv sends a command (RF) to the remote, and the remote transmits the IR command to the sonos bar.
This causes two problems. The first one is pretty clear: when changing the volume from the web remote control card while the physical remote is hiding in the couch or god knows where, the IR-command never reaches the sonos bar. Secondly a situation can arise where the TV 'thinks' it is muted whilst the sonos is unmuted. Since the TV does not stop outputting sound to the optical output when muted, this causes a mute icon when the sonos is unmuted and visa versa.
This pull request adds the possibility to add a custom media_player to control when a certain sound mode is selected or the device if off (control soundbar playing music when the tv is off).
Check the readme for details! Im planning to write a option to also control the host so the mute icon is displayed when the host is muted, but since the host sometimes unmutes the output device (when the remote is pointed at the soundbar) and the tv does not specify mute on/off but just toggles it this was a little more work then expected.