Fix 500 error in getChannelById and getChannelByName, removed topicDe…

…tails from returned object
madcoda · Jul 7, 2014 · b4d8883 · b4d8883
1 parent dd9e82a
commit b4d8883
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/lib/Madcoda/Youtube.php b/lib/Madcoda/Youtube.php
@@ -150,13 +150,16 @@ public function searchAdvanced($params)
      * @return \StdClass
      * @throws \Exception
      */
-    public function getChannelByName($username)
+    public function getChannelByName($username, $optionalParams = false)
     {
         $API_URL = $this->getApi('channels.list');
         $params = array(
             'forUsername' => $username,
-            'part' => 'id,snippet,contentDetails, statistics,topicDetails,invideoPromotion'
+            'part' => 'id,snippet,contentDetails,statistics,invideoPromotion'
         );
+        if($optionalParams){
+            $params = array_merge($params, $optionalParams);
+        }
         $apiData = $this->api_get($API_URL, $params);
         return $this->decodeSingle($apiData);
     }
@@ -166,13 +169,16 @@ public function getChannelByName($username)
      * @return \StdClass
      * @throws \Exception
      */
-    public function getChannelById($id)
+    public function getChannelById($id, $optionalParams = false)
     {
         $API_URL = $this->getApi('channels.list');
         $params = array(
             'id' => $id,
-            'part' => 'id,snippet,contentDetails, statistics,topicDetails,invideoPromotion'
+            'part' => 'id,snippet,contentDetails,statistics,invideoPromotion'
         );
+        if($optionalParams){
+            $params = array_merge($params, $optionalParams);
+        }
         $apiData = $this->api_get($API_URL, $params);
         return $this->decodeSingle($apiData);
     }

diff --git a/test/Madcoda/Tests/YoutubeTest.php b/test/Madcoda/Tests/YoutubeTest.php
@@ -125,7 +125,6 @@ public function testGetChannelByName()
         $this->assertObjectHasAttribute('snippet', $response);
         $this->assertObjectHasAttribute('contentDetails', $response);
         $this->assertObjectHasAttribute('statistics', $response);
-        $this->assertObjectHasAttribute('topicDetails', $response);
     }
 
     public function testGetChannelById()
@@ -138,7 +137,6 @@ public function testGetChannelById()
         $this->assertObjectHasAttribute('snippet', $response);
         $this->assertObjectHasAttribute('contentDetails', $response);
         $this->assertObjectHasAttribute('statistics', $response);
-        $this->assertObjectHasAttribute('topicDetails', $response);
     }
 
     public function testGetPlaylistsByChannelId()