Add Psalm taint annotations for XSS prevention #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds Psalm taint escape annotations for HTML security: - TwigRenderer::render: marks Twig rendering as HTML escape - ErrorPagerRenderer::render: marks error page rendering as HTML escape Twig's autoescape feature automatically escapes HTML entities in template output, making these methods safe sinks for HTML-tainted data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Psalm taint annotations to mark Twig rendering as HTML-safe (due to Twig's autoescape feature).
Changes
@psalm-taint-escape htmlon:TwigRenderer::render()- Twig autoescapes by defaultErrorPagerRenderer::render()- Error page renderingThis allows Psalm's taint analysis to understand that data passing through Twig templates is properly escaped for HTML output.
Test Plan
./vendor/bin/psalm --taint-analysisto verify annotations work