add [properties-be] - link parent and subtasks #610
Merged
+1,685
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whutchinson98
requested changes
Dec 15, 2025
rust/cloud-storage/document_storage_service/src/api/documents/delete_document.rs
Show resolved
Hide resolved
rust/cloud-storage/properties/src/outbound/task_property_queries.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/properties/src/outbound/task_property_queries.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/properties/src/outbound/task_property_queries.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/properties/src/outbound/task_property_queries.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/properties/src/outbound/task_property_queries.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/properties/src/outbound/task_property_queries.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/properties/src/outbound/entity_property_queries.rs
Outdated
Show resolved
Hide resolved
rust/cloud-storage/properties/src/outbound/entity_property_queries.rs
Outdated
Show resolved
Hide resolved
Add link_parent_task and link_subtasks methods to PropertiesRepo trait for atomic bidirectional linking between parent tasks and subtasks.
…to helper Move generic entity property update logic to entity_property_queries.rs for cleaner separation. No functionality change.
Implements atomic bidirectional linking for Parent Task and Subtasks properties. When setting a task's parent, the task is automatically added to that parent's subtasks (and removed from old parent's). When setting subtasks, each subtask's parent is updated accordingly.
Adds link_parent_task and link_subtasks to PropertiesService trait and implementation, delegating to the repository layer.
When setting Parent Task or Subtasks on a Task entity, the endpoint now calls the service layer's link methods for atomic bidirectional updates. Non-task entities fall through to normal upsert.
When a document is soft deleted, if it's a task, clear its Parent Task and Subtasks bidirectionally. This ensures deleted tasks don't appear in other tasks' relationships.
- Prevent tasks from being their own parent or subtask - Prevent mutual parent/subtask relationships (circular references) - Deduplicate subtask IDs before processing - Fix bug where parent subtasks updated for non-existent tasks
danielkweon
force-pushed
the
daniel/m-5401--add-properties-be-link-tasks-for-parent-and-sub
branch
from
f6b1e07 to
db6351b
Compare
whutchinson98
approved these changes
Dec 15, 2025
danielkweon
deleted the
daniel/m-5401--add-properties-be-link-tasks-for-parent-and-sub
branch
aidanhb
pushed a commit
that referenced
this pull request
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements bidirectional linking for task Parent Task and Subtasks properties. Changes to either property automatically update the other side atomically.
Behaviors:
Changes: