fix(email-service) Handle null attachment filename during upload #609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is an edge case where the file name for an attachment can be null. Updating the attachment upload logic to handle this. We now return an error if the caller attempts to upload a DSS attachment with a null filename (
nameinDocumenttable can't be null), whereas we upload image/video attachments with null filenames to SFS still (we don't care about the file name when uploading static media). Thenulledge case only appears to occur with image files anyway (how would you have a nameless pdf? not really possible)Adding tests to validate the queries that fetch documents to upload to DSS don't return attachments with null filenames.
Screenshots, GIFs, and Videos