Skip to content

Conversation

@evanhutnik
Copy link
Contributor

@evanhutnik evanhutnik commented Dec 13, 2025

Summary

There is an edge case where the file name for an attachment can be null. Updating the attachment upload logic to handle this. We now return an error if the caller attempts to upload a DSS attachment with a null filename (name in Document table can't be null), whereas we upload image/video attachments with null filenames to SFS still (we don't care about the file name when uploading static media). The null edge case only appears to occur with image files anyway (how would you have a nameless pdf? not really possible)

Adding tests to validate the queries that fetch documents to upload to DSS don't return attachments with null filenames.

Screenshots, GIFs, and Videos

@evanhutnik evanhutnik merged commit d7d7f9f into main Dec 15, 2025
36 checks passed
@evanhutnik evanhutnik deleted the evan/null-att-filename branch December 15, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants