-
Notifications
You must be signed in to change notification settings - Fork 3
Jacob's Split Tab Changes #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
i really don't agree with the tab changing size and position when active. feels extremely jank to me |
|
also, all of my custom tabs are now gone. is this intentional? |
Agreed. I also think there are too many tabs. This also eliminates the filter menu, which seems like an important piece of functionality. |
|
Yes, intentional that custom tabs are removed. I want to (I) get good defaults first and (ii) make filtering so fast that you don't care about saved tabs. Saved tabs are a crutch for slow filtering system. Very few users will create saved tabs. If the distribution of our users is tight enough -- which it should be by focusing on startups -- then we should be able to be opinionated on this. Is there a view you are missing in here that you really liked from your saved tabs @sedson ? I agree the slight shifting is not ideal but this is the least bad one I think
|
|
the missing custom views that i would want back are my unread-only inbox - for some reason i don't like marking channels as done – and my frecency sorted all view that hides ai. those are the views that i look at most. a kb shortcut for the toggle unread filter button would fix the first one this i guess. there are also some other bugs with this pr that would have to be addressed before merge and deploy.
|
|
Questions/observations:
|
No description provided.