Skip to content

Conversation

@peterchinman
Copy link
Contributor

No description provided.

@peterchinman peterchinman requested a review from a team as a code owner December 9, 2025 19:56
@sedson
Copy link
Contributor

sedson commented Dec 9, 2025

i really don't agree with the tab changing size and position when active. feels extremely jank to me

@sedson
Copy link
Contributor

sedson commented Dec 9, 2025

also, all of my custom tabs are now gone. is this intentional?

@peterchinman
Copy link
Contributor Author

i really don't agree with the tab changing size and position when active. feels extremely jank to me

Agreed. I also think there are too many tabs.

This also eliminates the filter menu, which seems like an important piece of functionality.

@jbecke
Copy link
Contributor

jbecke commented Dec 10, 2025

Yes, intentional that custom tabs are removed. I want to (I) get good defaults first and (ii) make filtering so fast that you don't care about saved tabs. Saved tabs are a crutch for slow filtering system. Very few users will create saved tabs. If the distribution of our users is tight enough -- which it should be by focusing on startups -- then we should be able to be opinionated on this.

Is there a view you are missing in here that you really liked from your saved tabs @sedson ?

I agree the slight shifting is not ideal but this is the least bad one I think

  • icons only not descriptive
  • text only runs wide
  • icons + text runs really wide

@sedson
Copy link
Contributor

sedson commented Dec 10, 2025

the missing custom views that i would want back are my unread-only inbox - for some reason i don't like marking channels as done – and my frecency sorted all view that hides ai. those are the views that i look at most. a kb shortcut for the toggle unread filter button would fix the first one this i guess.

there are also some other bugs with this pr that would have to be addressed before merge and deploy.

  • custom views are accessible with tab but do not show in the list
  • / for serach always puts me in all, ie no way to just search in notes without mouse clicks

@gbirman
Copy link
Contributor

gbirman commented Dec 10, 2025

Questions/observations:

  • Why are we moving search bar into a super narrow portion of the top bar? if the goal we're moving towards soon is a rich query language then search needs to be full width like it is currently
  • Why does search hotkey take you to all? Being able to search on your current view is desired behavior IMO. This will also break project block since you definitely expect to search within the project scope like we currently do.
  • I don't like that the all view doesn't let me filter by type any more since i like to use all as my home base and go from there. The original vision of soup/views is that these are all just mutable operations on the same list. now we have a completely different vision for this that regresses user customization for what real benefit? If we want to make it look cleaner we can just make it look cleaner without killing features IMO
  • I disagree that saved tabs are a crutch for a slow filtering system inasmuch as they are a crutch for not having to repeat the same clicks/typed input every time. also we don't know if no one's gonna use them until we start logging this info no? and even if we have a tight user distribution I think individual workflow is tough to narrow down since it's so personalized how people think about things

@peterchinman
Copy link
Contributor Author

peterchinman commented Dec 11, 2025

/ for serach always puts me in all, ie no way to just search in notes without mouse clicks
Why does search hotkey take you to all?

@sedson @gbirman this was intentionally changed to: / for All Search, cmd+f to search in current pane. Should add a hotkey indication in the search bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants