salt: update to version 3000.3

[aphor]

Description

major version bump, long awaited

Note the current port version has a remote execution vulnerability.
https://nvd.nist.gov/vuln/detail/CVE-2020-11651

Closes: https://trac.macports.org/ticket/60527

Tested on

macOS 10.14.6 18G4032
Xcode 11.3.1 11C504

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?

• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[aphor]

Depends on:

• py-pycryptodome: update to version 3.9.7 #7155
• py-smmap: update to version 3.0.4 #7157
• py-libcloud: update to version 3.0.0 #7158
• py-gitpython: update to version 3.1.2 #7159

Closes:

• https://trac.macports.org/ticket/60527

[macportsbot]

Travis Build #11706 Errored.

Lint results

--->  Verifying Portfile for salt
--->  0 errors and 0 warnings found.

The build timed out.

[mf2k]

In the commit message, you need to reference the Trac ticket that you (unnecessarily) created.

[macportsbot]

Travis Build #11936 Errored.

Lint results

--->  Verifying Portfile for salt
--->  0 errors and 0 warnings found.

Port salt's dependencies fail on xcode10.3. Log
Port salt's dependencies fail on xcode7.3. Log
Port salt-api's dependencies fail on xcode7.3. Log
Port salt-master's dependencies fail on xcode7.3. Log
Port salt-minion's dependencies fail on xcode7.3. Log
Port salt-syndic's dependencies fail on xcode7.3. Log

The build timed out.

[reneeotten]

@aphor the PRs on which this depends have been all merged or the changes committed. I think there are a few more things left here to fix.

[aphor]

Thanks for being so patient.

If you could review this, after we all like it, I will squash and force-push it so that you can have a squashed merge.

[reneeotten]

@aphor you added an extra revision line and set that to 0, but then later on you still have a line revision 1. That's of course not going to work.

Also, you should really make it a habit to build things locally before submitting/updating a PR. In this case adding a python38 / python37 variant of course requires all dependencies to have a subport for these versions, which isn't the case. It needs at least a py37/py38 subport for py-gnupg and it is also missing dependencies for the python35 variant. Please make sure to check with port lint --nitpick salt +variant, which you should do for each variant. So either you have to add the missing subports, or you cannot add these variants as of yet - either way is fine with me, I have no preference and don't use this port.

You can squash the commits when you make these final changes, just make sure to keep the "whitespace changes" separate and add separate commit for each py-port if you're going to add subports.

[macportsbot]

Travis Build #12081 Failed.

Lint results

--->  Verifying Portfile for salt
Error: Unknown dependency: py38-gnupg
--->  1 errors and 0 warnings found.

Port salt's dependencies fail on xcode10.3. Log
Port salt-api's dependencies fail on xcode10.3. Log
Port salt-master's dependencies fail on xcode10.3. Log
Port salt-minion's dependencies fail on xcode10.3. Log
Port salt-syndic's dependencies fail on xcode10.3. Log
Port salt's dependencies fail on xcode9.4. Log
Port salt-api's dependencies fail on xcode9.4. Log
Port salt-master's dependencies fail on xcode9.4. Log
Port salt-minion's dependencies fail on xcode9.4. Log
Port salt-syndic's dependencies fail on xcode9.4. Log
Port salt's dependencies fail on xcode8.3. Log
Port salt-api's dependencies fail on xcode8.3. Log
Port salt-master's dependencies fail on xcode8.3. Log
Port salt-minion's dependencies fail on xcode8.3. Log
Port salt-syndic's dependencies fail on xcode8.3. Log
Port salt's dependencies fail on xcode7.3. Log
Port salt-api's dependencies fail on xcode7.3. Log
Port salt-master's dependencies fail on xcode7.3. Log
Port salt-minion's dependencies fail on xcode7.3. Log
Port salt-syndic's dependencies fail on xcode7.3. Log

[aphor]

Thanks @reneeotten.

I broke my build test setup and needed to fix that, so I'm sorry for relying on the Macports builder system. I discovered a missing dependency once I had cleaned up. Sandboxing these builds is hard!

[reneeotten]

Sandboxing these builds is hard!

I assume that you're aware of the -t flag, which will do a build in trace-mode that disallows the use of any dependency other than the ones listed in your Portfile even if you have them installed on your system. But in this case you would see the missing dependencies already by just running port lint without building anything.

[aphor]

Also depends on #7385

[macportsbot]

Travis Build #12106 Failed.

Lint results

--->  Verifying Portfile for salt
Error: Unknown dependency: py38-gnupg
--->  1 errors and 0 warnings found.

Port salt's dependencies fail on xcode10.3. Log
Port salt-api's dependencies fail on xcode10.3. Log
Port salt-master's dependencies fail on xcode10.3. Log
Port salt-minion's dependencies fail on xcode10.3. Log
Port salt-syndic's dependencies fail on xcode10.3. Log
Port salt's dependencies fail on xcode9.4. Log
Port salt-api's dependencies fail on xcode9.4. Log
Port salt-master's dependencies fail on xcode9.4. Log
Port salt-minion's dependencies fail on xcode9.4. Log
Port salt-syndic's dependencies fail on xcode9.4. Log
Port salt's dependencies fail on xcode8.3. Log
Port salt-api's dependencies fail on xcode8.3. Log
Port salt-master's dependencies fail on xcode8.3. Log
Port salt-minion's dependencies fail on xcode8.3. Log
Port salt-syndic's dependencies fail on xcode8.3. Log
Port salt's dependencies fail on xcode7.3. Log
Port salt-api's dependencies fail on xcode7.3. Log
Port salt-master's dependencies fail on xcode7.3. Log
Port salt-minion's dependencies fail on xcode7.3. Log
Port salt-syndic's dependencies fail on xcode7.3. Log

[aphor]

Sandboxing these builds is hard!

I assume that you're aware of the -t flag, which will do a build in trace-mode that disallows the use of any dependency other than the ones listed in your Portfile even if you have them installed on your system. But in this case you would see the missing dependencies already by just running port lint without building anything.

This was a build error I didn't catch before because my macports test environment had some pip installed python components that I missed during cleanup of another test. This was never a salt dependency before, but is now. :( Totally my bad.

What would really be nice is a packaging system with an open-to-root file registry for tracking external packages and add-on junk.

[macportsbot]

Travis Build #12160 Errored.

Lint results

--->  Verifying Portfile for salt
--->  0 errors and 0 warnings found.

Port salt's dependencies fail on xcode7.3. Log
Port salt-api's dependencies fail on xcode7.3. Log

The build timed out.

[aphor]

Travis:
Installing dependency (10 of 157) 'pkgconfig' with variants '' (requesting '')
-->
Error: Portfile is from the future - check date and time of your system

[neverpanic]

lg2m

[reneeotten]

thanks @aphor @neverpanic and sorry, I forgot about this...