Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LucenePlusPlus: update to 3.0.8, fix build, add tests #21844

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented Dec 19, 2023

Description

Update, fix build, support testing.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

macOS 14.2
Xcode 15.1

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@barracuda156
Copy link
Contributor Author

barracuda156 commented Dec 19, 2023

Hmm, no failures with gcc build, but someone had a very similar issue elsewhere: https://stackoverflow.com/questions/46734274/c-cmake-build-with-cotire-and-gtest-error-with-float-h

Opened an issue with upstream, looks like a bug: luceneplusplus/LucenePlusPlus#199

@barracuda156
Copy link
Contributor Author

On PowerPC though:

[----------] Global test environment tear-down
[==========] 1472 tests from 201 test suites ran. (1756727 ms total)
[  PASSED  ] 1472 tests.

@barracuda156
Copy link
Contributor Author

I will just put tests into a variant. Anyway we did not have them, and without tests no errors with clang.

@barracuda156 barracuda156 marked this pull request as ready for review December 19, 2023 09:49
@reneeotten reneeotten merged commit 8f2aa54 into macports:master Dec 23, 2023
3 checks passed
@barracuda156 barracuda156 deleted the LucenePlusPlus branch December 24, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants