pextlib: return 2-element list from mkstemp #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or should |
|
Both look good to me. #309 has the advantage of being less code, which is always good. Less code is less code that Apple might break in the future. I quickly checked the ports tree, but didn't see any (Tcl) use of mktemp or mkstemp, so I think I'd go for #309. Feel free to merge either of them and close the other one. |
neverpanic
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…which when combined with the Tcl 8.5
lassigncommand should be simpler to use. The two uses updated by this PR are the only ones I am aware of.Hopefully this makes
mkstempa slightly more attractive replacement formktempwhich relies on themktemp()C function, which is deprecated since macOS 13 due to possible TOCTOU errors.