Fix fields holding smpl/cue offsets as they are in samples not bytes #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @SamWindell as they added those fields |
|
Looks good to me. Byte offset does seem wrong. I've checked the source code for JUCE as well and they read/write the value as samples not bytes. |
|
Thanks for this. I'll get this merged when I do another pass on dr_wav. Since this is breaking the API I might take the opportunity to make a few other changes I've got noted down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #267, I've just renamed the fields. This will cause breakages to users that can reevaluate their codebase wrt those fields.
Fixes #267