feat: SQDSDKS-5924 - Batching events with delay after app goes backgrounded#461
Open
markvdouw wants to merge 9 commits intodevelopmentfrom
Open
feat: SQDSDKS-5924 - Batching events with delay after app goes backgrounded#461markvdouw wants to merge 9 commits intodevelopmentfrom
markvdouw wants to merge 9 commits intodevelopmentfrom
Conversation
… batch upload Implementing as the legacy impl, a delayed message with type UPLOAD based on dynamic delay Adding feature flag ebb to "enableBackgroundBatching", read from config and default=false Adding Service for uploading Adding class in proguard Business logic changes on AppStateManager to route to different implementations based on feature flag. Business logic change at the upload handler level to dismiss automatic upload interval and upload at session end when batching is enabled.
Deprecating function in Media API Minor business logic changes in AppStatemanager Removing featrue flag on ConfigManager for platform consistency
sdk is backgrounded and there are no messages stored pending and the upload table is empty.
…ll events after app goes bachgrounded
einsteinx2
force-pushed
the
development
branch
from
a533731 to
32c788e
Compare
added 3 commits
December 14, 2023 10:58
Setting min alarm delay to 2mins Adding logic to handle both background event batching and current behavior Changing package receiver package name Removing comments
samdozor
force-pushed
the
development
branch
4 times, most recently
from
4759c74 to
a831780
Compare
rmi22186
force-pushed
the
development
branch
4 times, most recently
from
fca8a44 to
b67c108
Compare
Mansi-mParticle
force-pushed
the
development
branch
2 times, most recently
from
73f2388 to
5910509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Whenever the upload action is receive by our handlers and the batches are upload, we trigger a next upload message if the uploadInterval set by the user is greater than 0 and either
-The app isNotBackgrounded and the session is active OR
-The app isBackgrounded and either any of the batch upload failed and we would like to retry it in the future or there are messages ready to be sent in the future
When going to background an alarm is set based on the uploadInterval to upload batches even if the app is closed.
If the app is switched between background and foreground before scheduling a new alarm the previous one will be canceled.
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)