Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 and apply ruff as formatter #55

Merged
merged 9 commits into from
Feb 26, 2024

Conversation

hirosassa
Copy link
Collaborator

@hirosassa hirosassa commented Feb 18, 2024

What I did in this PR are

  • update actions version
  • add 3.12 to supported version and deprecate 3.8
  • apply ruff

Comment on lines +43 to +47
# Avoid automatically removing unused imports in __init__.py files.
ignore-init-module-imports = true

[tool.ruff.lint.per-file-ignores]
"__init__.py" = ["F401"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid unused imports error. I think this configurations are redundant but currently there's no workaround.

@hirosassa hirosassa requested a review from Hi-king February 18, 2024 06:46
Copy link
Member

@kitagry kitagry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- name: Set up Python
uses: actions/setup-python@v4
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent is broken?

@hirosassa
Copy link
Collaborator Author

@Hi-king @kitagry thx!

@hirosassa hirosassa merged commit 3e3d653 into m3dev:master Feb 26, 2024
5 checks passed
@hirosassa hirosassa deleted the support-py312 branch February 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants