Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds plugin support for PYON, allowing PYON to be extended with more complex data types
at the user's discretion.
Use Cases:
np.pi
.Example Plugin:
I included an example plugin in test_pyon_plugin.py. The short is that you need to add
a new encode & decode function for each type that you want to add. They look like roughly:
Notes
This is not the cleanest implementation. I was aiming for minimal diff with the existing PYON infrastructure,
hence leaving in _Encoder class.
If there is a reason to extend other sipyco functionality, the pluggy infrastructure could handle that equally well.
I included an example & test for this, and all existing PYON tests continue to pass.