-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix most staticcheck warnings #989
Conversation
Pull Request Test Coverage Report for Build 6422
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 36 of 38 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @gfr10598)
fake/fold.go, line 103 at r1 (raw file):
} return len(t) >= 0
This doesn't look correct to me. If len(t) is 1, the old code returns false but this code returns true. Right?
storage/rowwriter.go, line 29 at r1 (raw file):
o stiface.ObjectHandle // this attribute struct can be used to accumulate attributes that
Nit: can you capitalize? Go Style Decision: "Comments that are complete sentences should be capitalized and punctuated like standard English sentences."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @gfr10598)
fake/fold.go, line 103 at r1 (raw file):
} return len(t) >= 0
True enough - and no test coverage. 8-(
Closing this PR to clean up old PRs - the work to normalize the ETL codebases with standard Go static checks can be tracked in #1081 |
This PR fixes most of the warnings issued by the staticcheck tool.
There are a few warnings left, primarily for unused err values.
Testing:
Successful build + unit test coverage should be adequate, since these are expected to be strict refactorings and dead code deletions.
Test coverage stats should be checked to ensure modified lines are actually covered by unit tests.
This change is