Fix the implementation of StreamingXXHash32.asChecksum() #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trazfr
force-pushed
the
fix_StreamingXXHash32_Checksum
branch
from
aaa03d0
to
d4e0ea7
Compare
In the Checksum view, we only keep the last 28 bits of the hash instead of the 32 bits of the full hash.
trazfr
force-pushed
the
fix_StreamingXXHash32_Checksum
branch
from
d4e0ea7
to
ff795d9
Compare
…ream Before the PR, the 4 first bits were always set to 0 in LZ4Block*Stream. This commit keeps the current behaviour in LZ4Block*Stream to avoid breaking existing data built with this library
trazfr
force-pushed
the
fix_StreamingXXHash32_Checksum
branch
from
ff795d9
to
d010601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
Checksumview, we only keep the last 28 bits of the hash instead of the 32 bits of the full hash.The result is that the 4 first bits are always set to 0 in
LZ4Block*Stream.This PR:
Checksumview inStreamingXXHash32LZ4Block*Streamto avoid breaking existing data built with this library