add a reservoir for timers #171
Draft
+261
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciuszek
force-pushed
the
mattkuzminski/add-timer-reservoir
branch
from
98706b1 to
72bc838
Compare
maciuszek
commented
Jan 8, 2025
stats_test.go
Outdated
| counter = sink.record | ||
| if !strings.Contains(counter, expected) { | ||
| t.Error("wanted counter value of test.___f=i:1|c, got", counter) | ||
| expected = "test.__host=i:1|c" |
There was a problem hiding this comment.
Note: this test change is out of scope of this work but it was previously volatile with the order of reserved_tag vs test.__host not being deterministic
re-design with the notion of sample rate appended to the metric
improve naming
maciuszek
commented
Jan 11, 2025
| @@ -6,6 +6,7 @@ type Sink interface { | |||
| FlushCounter(name string, value uint64) | |||
| FlushGauge(name string, value uint64) | |||
| FlushTimer(name string, value float64) | |||
| FlushAggregatedTimer(name string, value, sampleRate float64) | |||
There was a problem hiding this comment.
Because of this we'll need a new major release.
The library usage should be backwards compatible, and additionally there is a feature flag to control the new behaviour, however if anything is implementing this interface it'll break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configurable reservoir implementation for timers. This should allow controlled stat load specifically for timers.