Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isolated build in docker #253

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added isolated build in docker #253

wants to merge 3 commits into from

Conversation

aido93
Copy link

@aido93 aido93 commented Mar 31, 2021

QTXDG_MINIMUM_VERSION changed to 3.4.0 (it is native to Ubuntu Focal) and added more accurate requirements to libraries. Binary appears in current directory after executing commands in Build section.

Copy link
Member

@tsujan tsujan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid QTXDG_MINIMUM_VERSION will be changed to 3.7.0 for the next release in April.

In addition, LXQt doesn't contain distro-specific codes.

@aido93
Copy link
Author

aido93 commented Apr 13, 2021

3.7.0 is not a problem.

Could you update dependency list in readme.md? It has differences with CMakeLists.txt.

Also, I tried to build the application in different environments such as Alpine, debian 8, debian 7, etc with different gcc version (7, 8, 9, 10) and I didn't manage to do it.

I managed to build it in isolated environment only for ubuntu:focal.

@tsujan
Copy link
Member

tsujan commented Apr 13, 2021

Could you update dependency list in readme.md? It has differences with CMakeLists.txt.

Yes, readme.md contains outdated info and needs to be updated. The reason may be that screengrab didn't belong to LXQt at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants