Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.sh #1122

Closed
wants to merge 1 commit into from
Closed

Update build.sh #1122

wants to merge 1 commit into from

Conversation

stefonarch
Copy link
Member

@stefonarch stefonarch commented May 12, 2024

Will still fail as qtermwidget-git doesn't exist yet.
EDIT: probably not true.

@stefonarch stefonarch marked this pull request as draft May 12, 2024 16:52
@yan12125
Copy link
Member

As a record, I gave up maintaining LXQt *-git packages used in CI (archlinuxcn/repo#3787). If you want to keep CI alive, you'll need to refresh -git packages first. See also lxqt/lxqt#1644 (comment) about concerns for the current approach.

@stefonarch
Copy link
Member Author

I didn't remember where to look for your comments, thanks.

@tsujan
Copy link
Member

tsujan commented May 12, 2024

If you want to keep CI alive...

CI was annoying to me from the start, although I learned how to tolerate it ;) I may be wrong, but I don't remember a single case where it has been really useful.

@yan12125
Copy link
Member

I don't remember a single case where it has been really useful.

It was useful when qtermwidget was ported to Qt 6 (lxqt/qtermwidget#532). At that time nobody tested the port with PyQt, and CI became a good reminder.

Anyway, the current CI approach brings more issues than it solves.

@stefonarch
Copy link
Member Author

but I don't remember a single case where it has been really useful

I remember that once I made a translation PR which went trough and blocked compiling, that was before weblate which prevents malformatted files. But as usually we compile all PRs locally we could do without CI.

I admire the CI of labwc which checks compiling on I don't know how many platforms, but that's one small binary which compiles here in 15 seconds or less.

@stefonarch
Copy link
Member Author

Atm I disabled CI testing in QTerminal and lxqt-panel.

@stefonarch stefonarch closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants