Tidy #1079
Merged
Tidy #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to clang-tidy.
Thanks to clang-tidy.
Thanks clang-tidy
It's fine to delete a null pointer. It has no effect. Assign nullptr after deleting make an access violation visible (crash).
Thanks clang-tidy.
|
Probably not. Some changes are not trivial, and I don't have time to dive into it these days. |
It's OK with me. |
|
At a glance those changes look good, but I still don't have time to investigate into details. As this pull request has been stuck for too long, let's test it in git-master instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.