Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Distros's logos to SVG format #69

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Changed Distros's logos to SVG format #69

merged 1 commit into from
Jul 20, 2021

Conversation

iamthesenate1
Copy link
Contributor

@iamthesenate1 iamthesenate1 commented Jun 28, 2021 •
edited
Loading

Closes #68. Sorry for the delay but some of them were really hard to find (I had to manually trace ROSA Linux one, for example)

@iamthesenate1 iamthesenate1 reopened this Jun 28, 2021
@iamthesenate1 iamthesenate1 changed the title Changed Distros's logos to SVG format Changed Distros's logos to SVG format (#68 ) Jun 28, 2021
@iamthesenate1 iamthesenate1 changed the title Changed Distros's logos to SVG format (#68 ) Changed Distros's logos to SVG format Jun 28, 2021
@iamthesenate1
Copy link
Contributor Author

Changed the LXQt logo to svg format too.

@iamthesenate1
Copy link
Contributor Author

iamthesenate1 commented Jul 1, 2021 •
edited
Loading

Sorry if I seem impolite, but is there a reason that this is not merged?

If there is, I would like to know so that I can fix the issue(s).

@tsujan
Copy link
Member

tsujan commented Jul 1, 2021 •
edited
Loading

Sorry if I seem impolite.

You're absolutely polite :)

It might take a while before an LXQt member finds the time to review a PR. I'm an LXQt member but have open PRs from a month ago that aren't reviewed yet.

@iamthesenate1
Copy link
Contributor Author

I understand. Thanks for explaining.

@tsujan tsujan mentioned this pull request Jul 2, 2021
Closed
3 tasks
@tsujan
Copy link
Member

tsujan commented Jul 10, 2021

@stefonarch, could you review it? I don't know much about the site.

stefonarch
stefonarch requested changes Jul 10, 2021
View reviewed changes
Copy link
Member

@stefonarch stefonarch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Archlinux logo has wrong filename and therefor isn't displayed.
Should be archlinux-logo-22.svg
Some of the SVG files need maybe a cleanup.

@iamthesenate1
Copy link
Contributor Author

Archlinux logo has wrong filename and therefor isn't displayed.
Should be archlinux-logo-22.svg

Done.

Some of the SVG files need maybe a cleanup.

Any one in particular? I retraced the ROSA Linux one, but I can't seem to be able to optimise much of the others.

@iamthesenate1 iamthesenate1 requested a review from stefonarch July 15, 2021 18:01
stefonarch
stefonarch reviewed Jul 16, 2021
View reviewed changes
Copy link
Member

@stefonarch stefonarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an issue with the mageia-logo-22.svg now, I see no problem in html:
schermata-07-16-22-29

@iamthesenate1
Copy link
Contributor Author

Looks like an issue with the mageia-logo-22.svg now, I see no problem in html:
schermata-07-16-22-29

This should be fixed now.

stefonarch
stefonarch approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@stefonarch stefonarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now, thanks!

@iamthesenate1
Replace distributions' logos with SVG's
ab3c869 
Replace distributions' logos with SVG's

Delete downloads.html

Add files via upload

Add files via upload

Change lxqt-white.png to lxqt-white.svg

Delete lxqt-white.png

(it is replaced by lxqt-white.svg)

Add lxqt-white.svg

Delete lxqt-white.svg

Add files via upload

Delete FreeBSD-logo-22.svg

Delete altlinux-logo-22.svg

Delete archlinux-logo.svg

Delete artix-logo-22.svg

Delete debian-logo-22.svg

Delete devuan-logo-22.svg

Delete fedora-logo-22.svg

Delete gentoo-logo-22.svg

Delete github-logo-22.svg

Delete mageia-logo-22.svg

Delete manjaro-logo-22.svg

Delete openmandriva-logo-22.svg

Delete opensuse-logo-22.svg

Delete rosa-linux-22.svg

Delete ubuntu-logo-22.svg

Delete void-logo-22.svg

Add Cleaned SVG's

ROSA and Mageia had his error: "Error: cleaned file is bigger than original."

Update FreeBSD-logo-22.svg

Update altlinux-logo-22.svg

Update archlinux-logo.svg

Update gentoo-logo-22.svg

Update artix-logo-22.svg

Update fedora-logo-22.svg

Update debian-logo-22.svg

Update devuan-logo-22.svg

Update manjaro-logo-22.svg

Update opensuse-logo-22.svg

Update github-logo-22.svg

Update openmandriva-logo-22.svg

Update ubuntu-logo-22.svg

Update void-logo-22.svg

Update lxqt-white.svg

Update lxqt_logo_and_name.svg

Update downloads.html

Delete lxqt_logo_and_name.svg

Add files via upload

Delete mageia-logo-22.svg

Add files via upload

Update lxqt_logo_and_name.svg

Delete rosa-linux-22.svg

Replaced with optimised version

Add opimised SVG

I had to retrace it because the old one could not be optimised and it was BIG(~60kb).

Delete rosa-linux-22.svg

Added (right) optimised ROSA Linux SVG

Last time I uploaded the wrong one.

Update rosa-linux-22.svg

Delete debian-logo-22.svg

Add files via upload

Update debian-logo-22.svg

Delete mageia-logo-22.svg

Add files via upload

Add files via upload
@stefonarch stefonarch merged commit fc6d93b into lxqt:master Jul 20, 2021
stefonarch added a commit that referenced this pull request Jul 20, 2021
@stefonarch
Revert "Replace distributions' logos with SVG's (#69)"
27f766f 
This reverts commit fc6d93b.
@stefonarch stefonarch mentioned this pull request Jul 20, 2021
Merged
stefonarch added a commit that referenced this pull request Jul 20, 2021
@stefonarch
Revert "Replace distributions' logos with SVG's (#69)" (#70)
861e5ea 
This reverts commit fc6d93b.
@stefonarch
Copy link
Member

stefonarch commented Jul 20, 2021 •
edited
Loading

I didn't notice it in my test, but rosa icon had the same issue now, I reverted the commit...
schermata-07-20-14-09

But IMHO it isn't a big issue using *.png icons on the website, I'm not sure if it is really worth all this work and testing.

@iamthesenate1
Copy link
Contributor Author

iamthesenate1 commented Jul 20, 2021 •
edited
Loading

For me it works fine (on two different laptops and in both firefox and chromium):
screen06
Can you test again?

But IMHO it isn't a big issue using *.png icons on the website, I'm not sure if it is really worth all this work and testing.

IMO this is the exact reason to continue. Why give up after all this work?

@tsujan
Copy link
Member

tsujan commented Jul 20, 2021

but rosa icon had the same issue now

Its sizes are in mm, which is wrong.

@tsujan
Copy link
Member

tsujan commented Jul 20, 2021

@iamthesenate1

You could make another PR with the correct SVG icons (check their sizes).

And please don't commit every change that you make to the source (e.g., deleting something, then adding something else, then deleting another thing,...); commit the changes together (deleting+adding+deleting+... as a single commit)!

@iamthesenate1
Copy link
Contributor Author

@tsujan Thank you for finding out the problem. I have opened #72 with the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefonarch stefonarch stefonarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distros's logos as svgs
3 participants
@iamthesenate1 @tsujan @stefonarch