mainmenu/fancymenu: Fix closing menu on "Meta" shortcut #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the workaround for closing the menu the Meta key is reported, whereas the shortcut in lxqt-globalkeys is Super_L. We make the workaround even dirtier and making it close upon Meta key even if the configured shortcut is Super_L or Super_R.
|
Tested and works, however my keyboard only has Super_L (no Super_R). If Super_L is registered in lxqt-globalkeys for the menu can Super_R erroneously trigger the same? |
Yes, as I've written in the comment. If the menu is open (by Super_L or mouse click), then it can be closed by Super_R, if pressed. |
tsujan
approved these changes
Oct 2, 2024
|
Tested too, works fine. GTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the workaround for closing the menu the Meta key is reported, whereas the shortcut in lxqt-globalkeys is Super_L.
We make the workaround even dirtier and making it close upon Meta key even if the configured shortcut is Super_L or Super_R.
Closes #2076
Closes #2132