Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fancy Menu: Shortcut behaviour #2076

Closed
libalis opened this issue Jul 16, 2024 · 7 comments · Fixed by #2133
Closed

[Bug] Fancy Menu: Shortcut behaviour #2076

libalis opened this issue Jul 16, 2024 · 7 comments · Fixed by #2133

Comments

@libalis
Copy link

libalis commented Jul 16, 2024

menu
settings

Expected Behavior
  • The shortcut should close the menu if it is already open
  • The buttons do not scale correctly
Current Behavior
  • The shortcut does nothing if the menu is already open, esc works
  • The buttons are way too big
Steps to Reproduce (for bugs)
  1. Press the shortcut
  2. Press it again
Context
  • My shortcut is set to Super_L, but that shouldn't make any difference
  • My sddm has the option EnableHiDPI set to true
System Information
  • LXQt Version: 2.0.0
  • Distribution & Version: openSUSE Tumbleweed
  • Qt Version: 6.7.2
  • liblxqt Version: 2.0.0

Finally, I would like to thank you for the great job you are doing with this big project in your spare time, thank you very much.

@stefonarch
Copy link
Member

stefonarch commented Jul 16, 2024

Confirming for the shortcut Super_L .
This key is handled differently to avoid conflicts with its use as a modifier: it triggers the menu at release, with other shortcuts there is no such issue.

Please open a separate issue for button scaling with exact steps to reproduce, it looks they don't scale according to font size.

@libalis
Copy link
Author

libalis commented Jul 16, 2024

Do you think the shortcut issue is solvable?

@libalis libalis changed the title [Bug] Fancy Menu: Shortcut behaviour and scaling [Bug] Fancy Menu: Shortcut behaviour Jul 16, 2024
@isf63
Copy link
Contributor

isf63 commented Jul 16, 2024

I use Super_L and if I remember correctly this happened with regular Application Menu too. Testing with lxqt-config-globalkeyshortcuts I can't get Super_L to hide the menu in either Application Menu or Fancy Menu.

@stefonarch
Copy link
Member

IMO the piece of code is the same in both menus.
Related commit is #1718

Do you think the shortcut issue is solvable?

@palinek ?

@libalis
Copy link
Author

libalis commented Jul 16, 2024

New issue for the scaling bug: #2077

@libalis
Copy link
Author

libalis commented Jul 17, 2024

Any updates from @palinek?

@palinek
Copy link
Contributor

palinek commented Oct 2, 2024

Seems like there may have been a change how Qt reports the keypress/release values, as this worked previously.
When debugging the workaround code for closing the menu I can observe, that the Meta key is reported, where as the shortcut in lxqt-globalkeys is Super_L (I don't have keyboard with Super_R to test).

The only way, I see now, is to make the workaround even dirtier and close the menu with Meta even if the shortcut is set to Super_L or Super_R.
(downside: in case the user would have both Super_L & Super_R on his/her keyboard, the menu would be closed by any of the buttons no matter if L or R is defined as the shortcut)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants