Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data in blocks gets saved even if exiting without pressing button "save" #199

Open
martinpetrasch opened this issue Jun 14, 2019 · 4 comments
Assignees

Comments

@martinpetrasch
Copy link
Contributor

What steps will reproduce the problem?

  1. Enter a block and edit data
  2. Exit block by clicking "Esc"

What is the expected result?

The new data shouldn't be saved.

What do you get instead? (A Screenshot can help us a lot!)

The data is saved.

Additional infos

Q A
LUYA Version dev-master (admin & cms)
@nadar
Copy link
Member

nadar commented Jun 14, 2019

but not in database? a reload will show the old data?

@nadar nadar self-assigned this Jun 16, 2019
@martinpetrasch
Copy link
Contributor Author

You're right. It's not saved in the database.

@TheMaaarc
Copy link
Member

The block should probably remember the data before editing and write it back if it's not saved.

@hbugdoll
Copy link
Member

zaaEsc only closes the editing modal.

Changing block data simultaneously changes the displayed block, which is overlayed by the modal.
Is this the desired behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants