Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement : TYPE_LINK Show or Hide options #104

Open
trk opened this issue Jun 21, 2018 · 3 comments
Open

Enhancement : TYPE_LINK Show or Hide options #104

trk opened this issue Jun 21, 2018 · 3 comments
Assignees

Comments

@trk
Copy link
Contributor

trk commented Jun 21, 2018

Want to use TYPE_LINK block field with telephone number or file and external url options, but don't want to show other options like: link target, internal page, email_address inside TYPE_LINK field or vice versa.

Is it possible to add filter options for this kind of usages?

@trk trk changed the title Enhancement : TYPE_LINK Show or Hide options Enhancement : TYPE_LINK Show or Hide options Jun 21, 2018
@trk trk changed the title Enhancement : TYPE_LINK Show or Hide options Enhancement : TYPE_LINK Show or Hide options Jun 21, 2018
@nadar nadar self-assigned this Jul 10, 2018
@nadar
Copy link
Member

nadar commented Feb 27, 2019

Yes, we could provide options for zaa-link directive.

@hbugdoll
Copy link
Member

hbugdoll commented Nov 1, 2021

@nadar Are hideTargetOption, hideInternalOption, hideExternalOption, hideFileOption, hideMailOption, hideTelephoneOption appropriate names for keys?

e.g.:

'vars' => [
   ['var' => 'mylink', 'label' => 'Link', 'type' => self::TYPE_LINK, 'options' => [
         'hideTargetOption' => true, 'hideInternalOption' => true, 'hideMailOption' => true
      ]
   ]
]

@nadar
Copy link
Member

nadar commented Nov 2, 2021

even we made that mistake also somewhere, but i would not prefix hide, just: targetOption = true/false (where true) is default value to not break BC. also i would add constants:

Link::TARGET_OPTION = true

(not sure where to put the constants yet, but you got the idea i think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants