Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ONNX version #56

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Updated ONNX version #56

merged 3 commits into from
Jan 15, 2025

Conversation

kozlov721
Copy link
Collaborator

Updating onnx package to version 1.17 to fix a discovered vulnerability

@kozlov721 kozlov721 requested a review from a team as a code owner December 10, 2024 16:43
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team December 10, 2024 16:43
klemen1999
klemen1999 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's check if this also affects anything in the #55 CC: @ptoupas

@ptoupas
Copy link
Contributor

ptoupas commented Dec 13, 2024 •
edited
Loading

@kozlov721 I think there might be an issue with the #55 if we are to move to 1.17 version.
Actually it does not have to do with #55 directly, its just that the test_config.py wont pass with onnx=1.17 version (at least this happens locally to me).

@kozlov721 kozlov721 force-pushed the fix/onnx-vulnerability branch from f966f48 to fcb40c4 Compare December 18, 2024 10:38
@kozlov721 kozlov721 merged commit ad557f9 into main Jan 15, 2025
1 check failed
@kozlov721 kozlov721 deleted the fix/onnx-vulnerability branch January 15, 2025 21:42
ptoupas pushed a commit that referenced this pull request Jan 16, 2025
@kozlov721 @ptoupas
Updated ONNX version (#56)
addc5f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klemen1999 klemen1999 klemen1999 approved these changes

@tersekmatija tersekmatija Awaiting requested review from tersekmatija tersekmatija is a code owner automatically assigned from luxonis/ml-reviewers

@conorsim conorsim Awaiting requested review from conorsim conorsim is a code owner automatically assigned from luxonis/ml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kozlov721 @ptoupas @klemen1999