Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings to the demo + USB2 warning #683

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add warnings to the demo + USB2 warning #683

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72d90a5
add warnings system
VanDavv Apr 14, 2022
e077be2
add ensureUsbSpeedMode function
VanDavv Apr 14, 2022
d2a3106
update warning text
VanDavv Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 56 additions & 6 deletions depthai_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def run_all(self, conf):
self.setup(conf)
self.run()

def __init__(self, displayFrames=True, onNewFrame = noop, onShowFrame = noop, onNn = noop, onReport = noop, onSetup = noop, onTeardown = noop, onIter = noop, onAppSetup = noop, onAppStart = noop, shouldRun = lambda: True, showDownloadProgress=None, collectMetrics=False):
def __init__(self, displayFrames=True, onNewFrame = noop, onShowFrame = noop, onNn = noop, onReport = noop, onSetup = noop, onTeardown = noop, onIter = noop, onWarning = noop, onAppSetup = noop, onAppStart = noop, shouldRun = lambda: True, showDownloadProgress=None, collectMetrics=False):
self._openvinoVersion = None
self._displayFrames = displayFrames
self.toggleMetrics(collectMetrics)
Expand All @@ -140,12 +140,16 @@ def __init__(self, displayFrames=True, onNewFrame = noop, onShowFrame = noop, on
self.onSetup = onSetup
self.onTeardown = onTeardown
self.onIter = onIter
self.onWarning = onWarning
self.shouldRun = shouldRun
self.showDownloadProgress = showDownloadProgress
self.onAppSetup = onAppSetup
self.onAppStart = onAppStart

def setCallbacks(self, onNewFrame=None, onShowFrame=None, onNn=None, onReport=None, onSetup=None, onTeardown=None, onIter=None, onAppSetup=None, onAppStart=None, shouldRun=None, showDownloadProgress=None):
def onError(self, error):
raise error # default behavior

def setCallbacks(self, onNewFrame=None, onShowFrame=None, onNn=None, onReport=None, onSetup=None, onTeardown=None, onIter=None, onWarning=None, onError=None, onAppSetup=None, onAppStart=None, shouldRun=None, showDownloadProgress=None):
if onNewFrame is not None:
self.onNewFrame = onNewFrame
if onShowFrame is not None:
Expand All @@ -160,6 +164,10 @@ def setCallbacks(self, onNewFrame=None, onShowFrame=None, onNn=None, onReport=No
self.onTeardown = onTeardown
if onIter is not None:
self.onIter = onIter
if onWarning is not None:
self.onWarning = onWarning
if onError is not None:
self.onWarning = onError
if shouldRun is not None:
self.shouldRun = shouldRun
if showDownloadProgress is not None:
Expand Down Expand Up @@ -209,6 +217,9 @@ def setup(self, conf: ConfigManager):
self._pm.setNnManager(self._nnManager)

self._device = dai.Device(self._pm.pipeline.getOpenVINOVersion(), self._deviceInfo, usb2Mode=self._conf.args.usbSpeed == "usb2")
if self._deviceInfo.desc.protocol == dai.XLinkProtocol.X_LINK_USB_VSC:
print("USB Connection speed: {}".format(self._device.getUsbSpeed()))
self._ensureUsbSpeedMode()
self._device.addLogCallback(self._logMonitorCallback)
if sentryEnabled:
try:
Expand All @@ -218,8 +229,6 @@ def setup(self, conf: ConfigManager):
pass
if self.metrics is not None:
self.metrics.reportDevice(self._device)
if self._deviceInfo.desc.protocol == dai.XLinkProtocol.X_LINK_USB_VSC:
print("USB Connection speed: {}".format(self._device.getUsbSpeed()))
self._conf.adjustParamsToDevice(self._device)
self._conf.adjustPreviewToOptions()
if self._conf.lowBandwidth:
Expand Down Expand Up @@ -344,7 +353,7 @@ def run(self):
if sentryEnabled:
from sentry_sdk import capture_exception
capture_exception(ex)
raise
self.onError(ex)
finally:
self.stop()

Expand All @@ -370,6 +379,32 @@ def stop(self, *args, **kwargs):
def canRun(self):
return hasattr(self, "_device") and not self._device.isClosed()

def _ensureUsbSpeedMode(self):
if self._device is None:
raise RuntimeError("Cannot determine USB speed without a device object!")

if self._device.getUsbSpeed() == dai.UsbSpeed.HIGH:
self.onWarning("Low USB speed detected. Expect reduced performance\nConsider using USB3 port or different cable")

if self._conf.args.usbSpeed != "usb2":
print("Enabling USB2 mode for USB2 connection...")
mxid = self._device.getMxId()
self._device.close()
del self._device
for i in range(5):
found, self._deviceInfo = dai.Device.getDeviceByMxId(mxid)
if found:
self._device = dai.Device(self._pm.pipeline.getOpenVINOVersion(), self._deviceInfo, usb2Mode=True)
self._conf.args.usbSpeed = "usb2"
break
else:
print(f"Device rediscovery failed... (Attempt: {i + 1})")
time.sleep(1)
if not hasattr(self, "_device") or self._device is None:
raise RuntimeError("Enabling USB2 mode failed, please try again with -usbs usb2 flag enabled!")
else:
print("Enabling USB2 mode was successful.")

def _logMonitorCallback(self, msg):
if msg.level == dai.LogLevel.CRITICAL:
print(f"[CRITICAL] [{msg.time.get()}] {msg.payload}", file=sys.stderr)
Expand Down Expand Up @@ -615,6 +650,7 @@ class WorkerSignals(QObject):
setDataSignal = pyqtSignal(list)
exitSignal = pyqtSignal()
errorSignal = pyqtSignal(str)
warningSignal = pyqtSignal(str)

class Worker(QRunnable):
def __init__(self, instance, parent, conf, selectedPreview=None):
Expand All @@ -639,7 +675,7 @@ def __init__(self, instance, parent, conf, selectedPreview=None):
def run(self):
self.running = True
self.signals.setDataSignal.emit(["restartRequired", False])
self.instance.setCallbacks(shouldRun=self.shouldRun, onShowFrame=self.onShowFrame, onSetup=self.onSetup, onAppSetup=self.onAppSetup, onAppStart=self.onAppStart, showDownloadProgress=self.showDownloadProgress)
self.instance.setCallbacks(shouldRun=self.shouldRun, onShowFrame=self.onShowFrame, onSetup=self.onSetup, onWarning=self.onWarning, onAppSetup=self.onAppSetup, onAppStart=self.onAppStart, showDownloadProgress=self.showDownloadProgress)
self.conf.args.bandwidth = "auto"
if self.conf.args.deviceId is None:
devices = []
Expand Down Expand Up @@ -694,6 +730,9 @@ def onError(self, ex: Exception):
self.signals.errorSignal.emit(''.join(traceback.format_tb(ex.__traceback__) + [f"{type(ex).__name__}: {ex}"]))
self.signals.setDataSignal.emit(["restartRequired", True])

def onWarning(self, text):
self.signals.warningSignal.emit(text)

def shouldRun(self):
if "shouldRun" in self.file_callbacks:
return self.running and self.file_callbacks["shouldRun"]()
Expand Down Expand Up @@ -771,6 +810,16 @@ def showError(self, error):
msgBox.setStandardButtons(QMessageBox.Ok)
msgBox.exec()


def showWarning(self, text):
print(f"[WARNING] {text}")
msgBox = QMessageBox()
msgBox.setIcon(QMessageBox.Warning)
msgBox.setText(text)
msgBox.setWindowTitle("Warning!")
msgBox.setStandardButtons(QMessageBox.Ok)
msgBox.exec()

def setupDataCollection(self):
try:
with Path(".consent").open() as f:
Expand All @@ -788,6 +837,7 @@ def start(self):
self.worker.signals.updateDownloadProgressSignal.connect(self.updateDownloadProgress)
self.worker.signals.setDataSignal.connect(self.setData)
self.worker.signals.errorSignal.connect(self.showError)
self.worker.signals.warningSignal.connect(self.showWarning)
self.threadpool.start(self.worker)
if not self.appInitialized:
self.appInitialized = True
Expand Down