Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move bigdecimal to optional type, fixes #44 #73

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

ronaldtse
Copy link
Contributor

@ronaldtse ronaldtse commented Sep 11, 2024

Fixes #44

This code is missing specs, we need to test the following cases:

  1. When bigdecimal is loaded, the Decimal type works (serialize into Lutaml::Model::Type::Decimal, deserialize into Ruby BigDecimal)
  2. When bigdecimal is not loaded, using the Decimal type (in serialize or deserialize) will raise the Lutaml::Model::Error::TypeNotSupportedError.

@HassanAkbar can you help? Thanks!

@ronaldtse ronaldtse assigned ronaldtse and unassigned HassanAkbar Sep 11, 2024
@ronaldtse ronaldtse removed the request for review from opoudjis September 11, 2024 03:44
@ronaldtse ronaldtse merged commit f7ba6d1 into main Sep 11, 2024
13 of 14 checks passed
@ronaldtse ronaldtse deleted the rt-make-bigdecimal-optional branch September 11, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make BigDecimal usage optional
2 participants