Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update render_default specs and add README #122

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Conversation

ronaldtse
Copy link
Contributor

@ronaldtse ronaldtse commented Oct 26, 2024

Fixes #120 (README)

@HassanAkbar I updated the spec here, and noticed that render_default does not work with key value mappings.

Can you please help add that here? Thanks.

@HassanAkbar
Copy link
Member

@ronaldtse Sure, I'm looking into it.

@HassanAkbar
Copy link
Member

@ronaldtse This is ready for review. I've also added the check to validate the options for attributes.

@ronaldtse
Copy link
Contributor Author

Thank you @HassanAkbar ! This looks great.

@ronaldtse ronaldtse merged commit 31b8a6d into main Oct 28, 2024
13 of 14 checks passed
@ronaldtse ronaldtse deleted the rt-readme-render-default branch October 28, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for render_default in README
2 participants