Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API reference + checkhostname + symbol visibility fix #49

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

bartbes
Copy link

@bartbes bartbes commented Jun 26, 2015

I realise it's a bit weird to send a pull request for 3 things at once, and if needed I can split them up and send 3 requests instead. Anyway, here goes:

  • I've created a small api reference, as that is something I couldn't find
  • I've add a checkhostname function that checks whether the peer's certificate is valid for the given hostname, and made https.request check it. Note that without such a check, anyone with a valid certificate for anything could easily pull of a man-in-the-middle attack.
  • I've changed the symbol visibility on linux so only the luasec api is exported

If there's any subset you want separated, give me a shout.

@bartbes
Copy link
Author

bartbes commented Jun 13, 2016

Is there any progress on this? It's been almost a year at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant