Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack around cliargs to provide "help" flag #732

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

TheMagician23
Copy link
Contributor

@TheMagician23 TheMagician23 commented Nov 23, 2023

Fixes #697

This change adds a check on the error returned from the cliargs library, and provides a "help" argument to the consumer code in busted/runner.lua.
It is based on the workaround used with the same library here: https://github.com/sile-typesetter/sile/pull/1737/files
except that the code in busted/runner.lua probably won't need to change if cliargs ever supports adding a --help flag in the "correct" way.

@alerque
Copy link
Member

alerque commented Dec 10, 2023

The upstream for cli_args has (since this PR was started) migrated the project to this org. I proposed this a long time ago but this PR made me ping the author again and this time it happened. Now that we can fix upstream I think we should fix this issue at the source and then just use it correctly in this project.

@TheMagician23
Copy link
Contributor Author

TheMagician23 commented Dec 12, 2023 via email

@TheMagician23
Copy link
Contributor Author

Okay, I've written a PR to improve the help system in lua_cliargs: lunarmodules/lua_cliargs#78

busted/runner.lua Outdated Show resolved Hide resolved
@alerque alerque merged commit 94d0081 into lunarmodules:master Oct 25, 2024
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Output --help to STDOUT
3 participants