Hack around cliargs to provide "help" flag #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The upstream for cli_args has (since this PR was started) migrated the project to this org. I proposed this a long time ago but this PR made me ping the author again and this time it happened. Now that we can fix upstream I think we should fix this issue at the source and then just use it correctly in this project. |
|
Hi Caleb.
This is fantastic news! I saw that lua_cliargs badly needed to be migrated to lunarmodules when I did my intial research, I'm glad you managed to make it happen.
I'll write a fix for the issue upstream soon; once it's done I'll comment on the issue in the busted repo with a link to the upstream fix.
Once it's in, you can throw away my original PR. Let me know if you want me to write a proper usage patch for busted after that fix goes in.
- The Magician
… Sent: Sunday, December 10, 2023 at 7:53 PM
From: "Caleb Maclennan" ***@***.***>
To: lunarmodules/busted ***@***.***>
Cc: "The Magician" ***@***.***>, Author ***@***.***>
Subject: Re: [lunarmodules/busted] Hack around cliargs to provide "help" flag (PR #732)
The upstream for cli_args has (since this PR was started) migrated the project to this org. I proposed this a long time ago but this PR made me ping the author again and this time it happened. Now that we *can fix upstream* I think we *should* fix this issue at the source and then just *use* it correctly in this project.
--
Reply to this email directly or view it on GitHub:
#732 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
Okay, I've written a PR to improve the help system in lua_cliargs: lunarmodules/lua_cliargs#78 |
alerque
approved these changes
Oct 22, 2024
Tieske
reviewed
Oct 24, 2024
Tieske
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #697
This change adds a check on the error returned from the
cliargslibrary, and provides a "help" argument to the consumer code inbusted/runner.lua.It is based on the workaround used with the same library here: https://github.com/sile-typesetter/sile/pull/1737/files
except that the code in
busted/runner.luaprobably won't need to change ifcliargsever supports adding a--helpflag in the "correct" way.