Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1477

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

🌐 New Crowdin updates #1477

wants to merge 3 commits into from

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Jan 3, 2025

Summary by CodeRabbit

  • Localization

    • Updated Turkish translations for multiple application sections
    • Added new localization entries for profile management, billing, and poll features
    • Improved grammatical accuracy of existing translations
    • Expanded language support with new terms and descriptions
  • New Features

    • Added profile picture management options
    • Introduced new poll management features
    • Enhanced billing and subscription terminology

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 3:28pm
landing ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 3:28pm

Copy link
Contributor

coderabbitai bot commented Jan 3, 2025

Walkthrough

This pull request focuses on enhancing the Turkish localization across multiple JSON files in the landing and web applications. The changes include correcting grammatical errors, adding new feature-related strings, and expanding localization coverage for profile management, billing, and poll-related features. The modifications span three different localization files, improving the Turkish language support and user experience.

Changes

File Changes
apps/landing/public/locales/tr/common.json - Corrected "Destekliyenler" → "Destekleyenler"
- Fixed "çevirilmesine" spelling
- Added "When2Meet Alternatifi"
- Added "Toplantı Anketi"
apps/landing/public/locales/tr/home.json - Updated headline and page creation text
- Added user and poll statistics strings
- Added When2Meet alternative references
- Added free scheduling poll title
apps/web/public/locales/tr/app.json - Added profile picture management strings
- Added file upload error messages
- Introduced poll feature localization
- Added billing and subscription-related terms

Possibly related PRs

Poem

🐰 A Rabbit's Localization Delight

Turkish words now shine so bright,
Polls and pages, crisp and clear,
Translations dancing without fear!
From "Destekliyenler" to "Destekleyenler" we leap,
Our language garden, no longer asleep! 🌈


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/web/public/locales/tr/app.json (1)

270-275: Standardize error message structure.

The error messages could be more consistent in their format. Consider standardizing the error messages to follow the same pattern:

-  "invalidFileTypeDescription": "Lütfen JPG veya PNG formatında bir dosya yükleyin",
-  "fileTooLargeDescription": "Lütfen 2MB'den küçük bir dosya yükleyin.",
-  "errorUploadPictureDescription": "Resminizi yüklerken bir hata oluştu. Lütfen tekrar deneyiniz.",
+  "invalidFileTypeDescription": "Lütfen JPG veya PNG formatında bir dosya yükleyin.",
+  "fileTooLargeDescription": "Lütfen 2MB'den küçük bir dosya yükleyin.",
+  "errorUploadPictureDescription": "Resminizi yüklerken bir hata oluştu. Lütfen tekrar deneyin."
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f72f713 and d328f9f.

📒 Files selected for processing (3)
  • apps/landing/public/locales/tr/common.json (2 hunks)
  • apps/landing/public/locales/tr/home.json (3 hunks)
  • apps/web/public/locales/tr/app.json (1 hunks)
🔇 Additional comments (5)
apps/landing/public/locales/tr/common.json (2)

9-9: LGTM! Grammar and spelling corrections look good.

The changes improve the Turkish grammar and spelling:

  • "Destekliyenler" → "Destekleyenler" (correct Turkish grammar)
  • "çevirilmesine" → "çevrilmesine" (correct spelling)

Also applies to: 14-14


26-28: LGTM! New translations are consistent.

The new entries maintain consistency with their English counterparts while following proper Turkish language conventions.

apps/landing/public/locales/tr/home.json (2)

13-14: LGTM! Proper number formatting implementation.

The statistics strings correctly use the ICU MessageFormat with the number and compact-short format for localized number display.


34-36: LGTM! Consistent branding maintained.

The When2Meet alternative strings maintain proper product name casing ("When2Meet") while following Turkish grammar rules for the rest of the text.

apps/web/public/locales/tr/app.json (1)

280-284: LGTM! Subscription-related translations are clear and consistent.

The translations for subscription periods, savings, and cancellation policy are accurate and maintain proper Turkish grammar while clearly conveying the subscription terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant