-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 New Crowdin updates #1477
base: main
Are you sure you want to change the base?
🌐 New Crowdin updates #1477
Conversation
[ci skip]
[ci skip]
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
WalkthroughThis pull request focuses on enhancing the Turkish localization across multiple JSON files in the landing and web applications. The changes include correcting grammatical errors, adding new feature-related strings, and expanding localization coverage for profile management, billing, and poll-related features. The modifications span three different localization files, improving the Turkish language support and user experience. Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/public/locales/tr/app.json (1)
270-275
: Standardize error message structure.The error messages could be more consistent in their format. Consider standardizing the error messages to follow the same pattern:
- "invalidFileTypeDescription": "Lütfen JPG veya PNG formatında bir dosya yükleyin", - "fileTooLargeDescription": "Lütfen 2MB'den küçük bir dosya yükleyin.", - "errorUploadPictureDescription": "Resminizi yüklerken bir hata oluştu. Lütfen tekrar deneyiniz.", + "invalidFileTypeDescription": "Lütfen JPG veya PNG formatında bir dosya yükleyin.", + "fileTooLargeDescription": "Lütfen 2MB'den küçük bir dosya yükleyin.", + "errorUploadPictureDescription": "Resminizi yüklerken bir hata oluştu. Lütfen tekrar deneyin."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/landing/public/locales/tr/common.json
(2 hunks)apps/landing/public/locales/tr/home.json
(3 hunks)apps/web/public/locales/tr/app.json
(1 hunks)
🔇 Additional comments (5)
apps/landing/public/locales/tr/common.json (2)
9-9
: LGTM! Grammar and spelling corrections look good.The changes improve the Turkish grammar and spelling:
- "Destekliyenler" → "Destekleyenler" (correct Turkish grammar)
- "çevirilmesine" → "çevrilmesine" (correct spelling)
Also applies to: 14-14
26-28
: LGTM! New translations are consistent.The new entries maintain consistency with their English counterparts while following proper Turkish language conventions.
apps/landing/public/locales/tr/home.json (2)
13-14
: LGTM! Proper number formatting implementation.The statistics strings correctly use the ICU MessageFormat with the
number
andcompact-short
format for localized number display.
34-36
: LGTM! Consistent branding maintained.The When2Meet alternative strings maintain proper product name casing ("When2Meet") while following Turkish grammar rules for the rest of the text.
apps/web/public/locales/tr/app.json (1)
280-284
: LGTM! Subscription-related translations are clear and consistent.The translations for subscription periods, savings, and cancellation policy are accurate and maintain proper Turkish grammar while clearly conveying the subscription terms.
Summary by CodeRabbit
Localization
New Features