Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure that errors from before hook are reported #196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmcdo29
Copy link

@jmcdo29 jmcdo29 commented Feb 26, 2022

I've added in a try/catch to catch any errors that happen in the before hook so that they can be reported on and properly have the exit code of 1. If you'd like me to update any of the code styles, let me know. Been loving this test runner so far.

Closes #191
Closes #201

@jmcdo29
Copy link
Author

jmcdo29 commented Mar 18, 2022

@lukeed sorry to be a bother with the ping, just wondering if we can get this looked at? I've loved using uvu so far and want to make it my defacto test runner, this is the missing piece for me at the moment (writing try/catch in the before is rather cumbersome to continually do)

@skibz
Copy link

skibz commented Jul 12, 2022

Please review this for merge. It's a huge quality-of-life improvement to this library.

@randomer
Copy link

Just stumbled upon this bug. Is there any chance of it getting merged anytime soon?

PS: @lukeed Thanks for this library, it's easily the fastest JS test runner I've ever used!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants